Skip to content

Replay comment box visible#20

Open
mdhsieh wants to merge 2 commits into
knightron0:mainfrom
mdhsieh:fix-12-replay-comment-box-visible
Open

Replay comment box visible#20
mdhsieh wants to merge 2 commits into
knightron0:mainfrom
mdhsieh:fix-12-replay-comment-box-visible

Conversation

@mdhsieh

@mdhsieh mdhsieh commented Nov 22, 2024

Copy link
Copy Markdown
Contributor

#12 Hide the replay comment box when a video has no comments. But don't affect its config for other videos, like when toggling the view and a video has comments.

@knightron0

Copy link
Copy Markdown
Owner

i'm not sure why but this stops fetching comments for videos i access through recommendations. more specifically, if I go from one video to another, the comments don’t load for the second one (i have to refresh to make them load)

if i remember correctly, i faced a similar issue when i tried to implement this in the past – i can take a deeper look soon!

@mdhsieh

mdhsieh commented Nov 22, 2024

Copy link
Copy Markdown
Contributor Author

Huh, good catch :) That's strange.

@mdhsieh

mdhsieh commented Nov 24, 2024

Copy link
Copy Markdown
Contributor Author

Does that have anything to do with this error? It's shown up before I've made any changes:

Error handling response: TypeError: chrome.tabs.executeScript is not a function at chrome-extension://llbkbaagafolhbpceejpbcgmkniaifkm/background.js:160:19

Unchecked runtime.lastError: Could not establish connection. Receiving end does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants