This repository was archived by the owner on Aug 20, 2025. It is now read-only.
Fixed #23 -- Changed hardcoded admin index URL. #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the code to dynamically get the admin index URL by leveraging the json_script templates tag.
for more information, see https://pre-commit.ci
knyghty
suggested changes
Mar 24, 2025
Comment on lines
17
to
23
| if (adminIndexElement) { | ||
| const adminIndexUrl = JSON.parse(adminIndexElement.textContent); | ||
| document.location.href = adminIndexUrl; | ||
| } else { | ||
| // Fallback to default if element not found | ||
| document.location.href = "/admin/"; | ||
| } |
Owner
There was a problem hiding this comment.
I don't really see a point to the conditional, it will always be true.
I also don't know if it's needed to use JSON.parse() or not. Maybe it is, but I feel like it's just a string so it isn't really doing anything.
Author
There was a problem hiding this comment.
I used JSON.parse() because it was used in the example shared in the documentation. I will read more on it to see if it's really needed in this situation.
Removed unnecessary conditional check for element existence since it will always be present in the template. Kept JSON.parse() as it's necessary when using json_script because the template tag serializes values to JSON format, wrapping even simple strings in quotes. Without it, navigation would fail due to the browser attempting to navigate to a URL with quotation marks.
for more information, see https://pre-commit.ci
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the code to dynamically get the admin
index URL by leveraging the json_script templates tag.