Skip to content

fix: localize basemap place labels by active app language#1027

Merged
koala73 merged 1 commit intomainfrom
fix/map-label-localization-clean
Mar 5, 2026
Merged

fix: localize basemap place labels by active app language#1027
koala73 merged 1 commit intomainfrom
fix/map-label-localization-clean

Conversation

@koala73
Copy link
Owner

@koala73 koala73 commented Mar 5, 2026

Summary

  • Localizes MapLibre basemap place-name labels to match the app's active i18n language
  • Uses coalesce expression to try localized name → generic namename_en fallback
  • Applied on initial map load and after theme switches (style reload)

Changes

  • DeckGLMap.ts: new applyBasemapLocalization() method iterates symbol layers on source-layer: 'place' and replaces text-field with a coalesce expression for the current language
  • Called after initDeck() and inside style.load callback on theme change

Test plan

  • Switch app language to a non-English locale (e.g., French, Arabic, Chinese)
  • Verify map place labels display in the selected language
  • Switch theme (dark ↔ light) and confirm labels remain localized
  • Verify English fallback works for places without translations

@vercel
Copy link

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
worldmonitor Ready Ready Preview, Comment Mar 5, 2026 2:19am

Request Review

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@koala73 koala73 merged commit 9d247f7 into main Mar 5, 2026
3 checks passed
@koala73 koala73 mentioned this pull request Mar 5, 2026
koala73 added a commit that referenced this pull request Mar 5, 2026
koala73 added a commit that referenced this pull request Mar 5, 2026
koala73 added a commit that referenced this pull request Mar 5, 2026
koala73 added a commit that referenced this pull request Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant