fix: replace hardcoded FIRMS error with localized no-data message#1035
Merged
fix: replace hardcoded FIRMS error with localized no-data message#1035
Conversation
The fires panel showed "NASA_FIRMS_API_KEY not configured" whenever detections were empty, which is misleading — empty data can have multiple causes (seed cron lag, Redis expiry, circuit breaker). Use the existing i18n key `panels.satelliteFires.noData` instead, which is already translated across all 21 supported languages.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
t('panels.satelliteFires.noData')→ "No fire data available" (already translated in all 21 locales)Changes
src/services/wildfires/index.ts— changedreasonfrom API-key-specific string to generic'no_data'src/app/data-loader.ts— replaced hardcoded English string witht()callTest plan