fix(ui): replace biased array shuffle with Fisher-Yates algorithm

[NewCoder3294]

Summary

• Replace biased array.sort(() => Math.random() - 0.5) with a proper Fisher-Yates (Knuth) shuffle in the search modal's tip randomization (SearchModal.ts line 301).
• Add a reusable shuffle<T>() utility to src/utils/index.ts that returns a new array without mutating the original.
• No other instances of the biased sort pattern were found elsewhere in the codebase.

Why this matters

Using sort() with a random comparator produces statistically biased results. The ECMAScript spec does not define a particular sorting algorithm, so the distribution of permutations depends on the engine's implementation (e.g., V8 uses TimSort). A random comparator violates the requirement that the comparator be consistent and transitive, meaning some orderings appear significantly more often than others.

The Fisher-Yates shuffle (also known as the Knuth shuffle) guarantees a uniformly random permutation in O(n) time by iterating backwards through the array and swapping each element with a randomly chosen element from the remaining unprocessed portion.

Changes

File	Change
src/utils/index.ts	Add generic shuffle<T>(arr: T[]): T[] utility function
src/components/SearchModal.ts	Import shuffle from utils; replace tips.sort(() => Math.random() - 0.5) with shuffle(tips)

Test plan

• TypeScript compiles cleanly (tsc --noEmit)
• Verify search modal empty state still shows 4 randomized tips when opened
• Confirm tips appear in varying order across multiple opens

🤖 Generated with Claude Code

[vercel]

@NewCoder3294 is attempting to deploy a commit to the Elie Team on Vercel.

A member of the Team first needs to authorize it.