Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for excluding selected submaps from either the current map or the incoming map during session merging in the offline viewer.
This is useful for patching part of an existing map with data from another mapping session, while excluding outdated, unreliable, or otherwise unwanted regions from either side of the merge.
Changes
Find overlapping submaps.Implementation overview
graph_metadatagraph.txtparsing with optional pruning records while remaining compatible with legacy metadata.graph_editglobal_mappingcallbacks,async_global_mapping, andglobal_mapping_baseinteractive_viewermanual_loop_close_modaloffline_viewerSession merge workflow
Find overlapping submapsto reconnect the graph.Gauge handling
The current map remains the reference frame for the merged graph.
If pruning removes the submap containing the current pose gauge anchor, the gauge constraint is transferred to the first remaining current-map submap while preserving the original constraint strength.
The incoming session does not retain an independent pose gauge during the merge, consistent with the existing additional-map loading behavior.
Compatibility
When no submap is selected for pruning, the existing session merge workflow is preserved.