Fix type_hooks handling for dictionary keys - #277
Open
NikitaTolpikin wants to merge 3 commits into
Open
NikitaTolpikin wants to merge 3 commits into
NikitaTolpikin wants to merge 3 commits into
Conversation
Collaborator
|
@konradhalas Are you able to confirm this was an unintended change in behavior? Changelog does not mention it explicitly anywhere. |
# Conflicts: # dacite/core.py
Author
|
@mciszczon @konradhalas Any updates? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Found a bug in your lib while migrating to a newer version. In version 1.6.0, type_hooks were applied to both dictionary keys and values. However, after upgrading to version 1.9.1, I noticed that type_hooks are no longer applied to dictionary keys, only to values.
This PR restores the previous behavior, ensuring that type_hooks are consistently applied to both dictionary keys and values, just like in version 1.6.0. This change should improve backward compatibility and maintain expected behavior for users relying on type_hooks.
Let me know if any adjustments or additional tests are needed!
Fixes #217 #252