fix(code-block)!: errors following a full review of the component (#DS-5482)

[artembelik]

What

A full review of code-block, in the same shape as the 20.3.0 component reviews.

maxHeight lied about being required

readonly maxHeight = input<number, unknown>(undefined!, { transform: numberAttribute });

A code block with no [maxHeight] binding reported undefined from a non-nullable type: an assignment to a number held undefined, and maxHeight() > 0 was a NaN comparison that never matched. It reports number | undefined now — the same pathology, and the same fix, as KbqSplitButton.disabled in the first review wave.

KbqCodeBlockHighlight.file was write-only

@Input({ required: true })
set file(file: KbqCodeBlockFile) { … this.highlight(file); }

A required input with no getter, whose setter kicked off highlighting as a side effect — which is exactly why the automated signal migration skipped it. It is input.required() driven by an effect now, so it can finally be read.

The max-height binding never re-evaluated on its own

calculatedMaxHeight was a getter read from [style.max-height.px], so it only recomputed when something else marked the view dirty. It is a computed over maxHeight and viewAll now.

That binding turned out to have no test coverage at all — the new test caught a mistake I made in the very same change (binding the computed without calling it), which is worth knowing about the component.

What deliberately stays an accessor input

softWrap, viewAll, canDownload, activeFileIndex and files are backed by signals now, but stay accessor inputs with the same types and the same two-way …Change outputs. They are written by the component (toggleSoftWrap(), onSelectedTabChange()) as well as by the binding, and a model() cannot carry the booleanAttribute / numberAttribute transform a valueless attribute needs — the same conclusion checkbox and the reviewed button-toggle reached.

No call site changes for those five. What does change is that a template reading them re-renders on its own instead of waiting for change detection, and the // TODO: Skipped for migration comments are gone.

Migration

code-block-optional-max-height runs from ng update @koobiq/components@20. It is warn-only: narrowing number | undefined back to number is a decision the call site owns, and turning a file write into a [file] binding is a template edit.

Documented in docs/guides/migration.{en,ru}.md, section 18.

Testing

• code-block.spec.ts: 50 → 53 tests. New coverage for the unbound maxHeight, the max-height style the component applies and drops on viewAll, and the now-readable file on the highlight directive.
• code-block-optional-max-height/index.spec.ts: 4 tests.
• Full packages/components (4996 tests) and packages/schematics (438 tests) suites pass.
• check-api is in sync.

BREAKING CHANGE

🤖 Generated with Claude Code