ci: run the pipeline on the koombea-ci self-hosted runner - #8
Draft
fabolivark wants to merge 1 commit into
Draft
fabolivark wants to merge 1 commit into
fabolivark wants to merge 1 commit into
Conversation
A pull request from another fork keeps running on ubuntu-latest, so untrusted code never reaches the server. The job is routed rather than skipped: a skipped job never reports, and a required check that never reports blocks the pull request forever. The first clause is what keeps the push trigger on the server, since github.event.pull_request is null outside a pull request. Release and image publishing stay on ubuntu-latest: publishing should not depend on the server being up.
|
Thanks for the pull request. Before it can be merged, please read the Individual Contributor License Agreement and sign it by posting the comment below. You keep the copyright in your contribution, and It's a Plan stays open source. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Routes the three CI jobs to the
koombea-ciself-hosted runner, following the org's migration convention:A pull request opened from another fork stays on
ubuntu-latest, so untrusted code never runs on the server. The job is routed, never skipped with anif:— a skipped job never reports, and a required check that never reports blocks the pull request forever.The leading
github.event_name != 'pull_request'is what keeps thepush: branches: [main]trigger on the server: outside a pull requestgithub.event.pull_requestis null.release.ymlandpublish-images.ymlstay onubuntu-latest— publishing and releasing should not depend on the server being up, and image publishing needs the arm64 matrix runners.cla.ymlandpr-title.ymlstay too: they run for fork pull requests, which the guard routes toubuntu-latestanyway, and they invoke no repository tooling.Why
The org runs its CI on
koombea-ci. This repository was still entirely on GitHub-hosted runners.How to test
This pull request is also a probe. No workflow of this repository has ever run in
koombea/itsaplan:ci.ymlreportsstate: activewith zero runs in its whole history, and the repository's only three Actions runs are Copilot'sdynamicworkflow. The merge of #7 was a push tomain, whichci.ymlsubscribes to, and it triggered nothing.Ruled out so far: Actions is enabled at repository level (
allowed_actions: all), enabled org-wide (enabled_repositories: all),ci.ymlis present on the default branch, default workflow permissions arewrite, and the fork banner is not on the Actions tab.So the first thing to read on this pull request is whether any check appears at all.
Checklist
bun run typecheckpasses — unaffected, no source changebun run lintandbun run format:checkpass —prettier --checkclean on the file.env.example— noKnown risk
The
Test suitejob is the heaviest in the repository: it builds the production api image and runs Postgres, MinIO and 1947 tests. Akoombea-cilane is 3 threads and 7 GiB split between the runner and its dind. Watch this job's memory before making it a required status check.