Attempt to remove implementation notes #801 and #1261 for both keyed and non-keyed#2039
Open
Eric-P7 wants to merge 1 commit into
Open
Attempt to remove implementation notes #801 and #1261 for both keyed and non-keyed#2039Eric-P7 wants to merge 1 commit into
Eric-P7 wants to merge 1 commit into
Conversation
…provements main.js (keyed + non-keyed): replace h.memo() with h.map() (object-identity reuse, framework-layer caching like Solid <For>/Lit repeat), and drop the eventDelegation:true option since delegation is now on by default in Solarite. Switch the relevant updates to immutable replacement (required by h.map). Solarite.min.js: optimized build (39.4 -> 35.3 KB minified). package.json: remove the issues [801, 1261] array on both entries. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to remove implementation notes #801 and #1261 for both keyed and non-keyed. Along with possible performance improvements.
Let me know if you'd like me to change anything. And thanks for maintaining all this.