Repository navigation
[LOW] Escape untrusted values in the documentation playground - #844
Open
OskarEichler wants to merge 1 commit into
Open
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The documentation playground renders result fields with Vue v-html. Raw JSON values were returned without escaping when match highlighting was disabled or when a displayed field had no match. A pasted payload such as an img element with an onerror handler therefore executed in the Fuse.js documentation origin.
The vulnerable path was introduced by the VitePress playground and is present in releases v7.4.0 through v7.5.0. This affects the public documentation playground, not the Fuse.js runtime package.
Fix
Move result rendering into a small pure helper and escape every user-controlled value before adding the one trusted mark element generated by the playground.
Verification
Breaking changes
None.