Skip to content

[LOW] Pin actions/checkout to its reviewed commit - #845

Open
OskarEichler wants to merge 1 commit into
krisk:mainfrom
OskarEichler:codex/security-pin-checkout
Open

OskarEichler wants to merge 1 commit into
krisk:mainfrom
OskarEichler:codex/security-pin-checkout

Conversation

@OskarEichler

Copy link
Copy Markdown

Issue

Both workflows execute actions/checkout through the mutable v4 tag. If that upstream tag were retargeted after an action compromise, substituted code would execute inside Fuse.js CI. The documentation workflow grants contents: write.

Fix

Pin both checkout uses to commit 11d5960a326750d5838078e36cf38b85af677262, the commit currently referenced by v4. The version comment keeps Dependabot and reviewers aware of the intended major release.

Verification

  • Confirmed the SHA resolves from the assessed v4 tag
  • Both workflow files parse successfully as YAML
  • git diff --check passed

Breaking changes

None.

@lbesecker195 lbesecker195 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified actions/checkout tag v4 resolves to commit 11d5960a326750d5838078e36cf38b85af677262 (lightweight tag, so no dereferencing needed), and those are the only two checkout@v4 uses in deploy-docs.yml and nodejs.yml on main. Heads up that #846 edits the line right below in both files, so whichever lands second will likely need a rebase. LGTM.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants