Repository navigation
Conversation
Author
|
The Node.js CI run now reports: “This workflow run required approval but was not approved before it expired.” It has no jobs, so the failure shown is approval expiry, not a test result. The PR is unchanged at |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fractional search limit returns one extra result on the heap path:
limit: 0.5returns one match, andlimit: 1.5returns two. This differs from the existingslice(0, limit)behavior used by unlimited sorting, logical queries, andshouldSort: false.Use heap selection only for positive integer limits, preserving the existing slice behavior for other values. Add regressions for string and object collections and rebuild the distributions.
Validation: six regression cases fail before the fix; all 455 tests, build, lint, typecheck, and formatting checks pass.