Repository navigation
Simplify Endpoints row navigation after the SSE NgZone fix - #201
Merged
Merged
Conversation
Signed-off-by: Harshit Nayan <harshitacademia@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the previously required Dashboard-mode “full reload” navigation workaround and manual change detection calls now that SSE callbacks run inside Angular’s zone (per #197), restoring straightforward router-based navigation while allowing iframe click events to propagate for Central Dashboard URL mirroring.
Changes:
- Simplifies Endpoints name-link navigation to always use
router.navigate()and stops suppressing event propagation for normal clicks. - Removes the Dashboard parent-window URL rewrite / fallback frame reload logic and associated test coverage.
- Removes manual
ChangeDetectorRef.detectChanges()calls in the SSE subscriber.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
frontend/src/app/pages/index/index.component.ts |
Drops dashboard-specific navigation + manual change detection; keeps click propagation while preventing default anchor load. |
frontend/src/app/pages/index/index.component.spec.ts |
Updates Jest coverage to assert router navigation and no stopPropagation() for normal name-link clicks; removes tests for the deleted reload workaround. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With SSE events running inside the Angular zone (#197), plain router navigation renders the details page correctly, so the Dashboard page load workaround from #194 is removed. The navigation click no longer stops propagation, because the Central Dashboard mirrors the iframe location into the address bar from a click listener on the iframe document. The manual detectChanges calls in the SSE subscriber were compensating for the same out-of-zone condition and are removed.
fixes: #200