Overloading functions to allow custom allocators

[MikaelHuppunen]

No description provided.

[kstppd]

@MikaelHuppunen this looks good and passes the CI test locally on my machine. However would you still want to add a small unit test somewhere?

[kstppd]

same question for all these pretty much

[MikaelHuppunen]

The functions would then break if ALLOCATOR is defined but BLOCKSIZE and WARP are not (or the other way around depending on the order of the arguments).

[MikaelHuppunen]

@MikaelHuppunen this looks good and passes the CI test locally on my machine. However would you still want to add a small unit test somewhere?

Is there an existing unit test that tests extractPatternLoop and extractAllKeysLoop? I could then do that but with a custom allocator.

[kstppd]

@MikaelHuppunen this looks good and passes the CI test locally on my machine. However would you still want to add a small unit test somewhere?

Is there an existing unit test that tests extractPatternLoop and extractAllKeysLoop? I could then do that but with a custom allocator.

@MikaelHuppunen yup there are a couple of test cases here

https://github.com/kstppd/hashinator/blob/master/unit_tests/stream_compaction/unit.cu

[kstppd]

This is the diff on the meson file

diff --git a/meson.build b/meson.build
index 5c10eb6..fd37248 100644
--- a/meson.build
+++ b/meson.build
@@ -30,6 +30,7 @@ insertion_mechanism = executable('insertion', 'unit_tests/insertion_mechanism/ma
 tombstoneTest = executable('tbPerf', 'unit_tests/benchmark/tbPerf.cu', dependencies :gtest_dep)
 realisticTest = executable('realistic', 'unit_tests/benchmark/realistic.cu', dependencies :gtest_dep)
 hybridGPU = executable('hybrid_gpu', 'unit_tests/hybrid/main.cu',dependencies :gtest_dep )
+customAllocatorTest = executable('custom_allocator', 'unit_tests/custom_allocator/unit.cu',dependencies :gtest_dep )


 #Test-Runner
@@ -48,3 +49,4 @@ test('hybridCPU_Test',  hybridCPU)
 test('hybridGPU_Test',  hybridGPU)
 test('TbTest',  tombstoneTest)
 test('RealisticTest',  realisticTest)
+test('CustomAllocator',  customAllocatorTest)

in an attempt to integrate your unit test there

but fails to compile due to

../unit_tests/custom_allocator/unit.cu(198): error: no instance of overloaded function "split::tools::copy_if_loop" matches the argument list
            argument types are: (vector, vector, lambda [](test_t)->bool)
     split::tools::copy_if_loop(*v,*output1,predicate_on);
     ^
../unit_tests/custom_allocator/../../include/splitvector/split_tools.h(1015): note #3327-D: candidate function template "split::tools::copy_if_loop(split::SplitVector<T, split::split_unified_allocator<T>> &, split::SplitVector<T, split::split_unified_allocator<T>> &, Rule, cudaStream_t)" failed deduction
  void copy_if_loop(split::SplitVector<T, split::split_unified_allocator<T>>& input,
       ^
../unit_tests/custom_allocator/../