fix(async-upload): scope S3 downloads to directory prefix - #3066
Open
immanuwell wants to merge 1 commit into
Open
fix(async-upload): scope S3 downloads to directory prefix#3066immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
Assisted-by: Codex Signed-off-by: immanuwell <pchpr.00@list.ru>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
pboyd
reviewed
Aug 11, 2026
|
|
||
| bucket_name = config.bucket | ||
| prefix = config.key | ||
| prefix = config.key if config.key.endswith("/") else f"{config.key}/" |
Member
There was a problem hiding this comment.
Thanks for the PR, @immanuwell.
One question though, what happens if config.key were my-model/model.onnx? I believe that would work today, but it would break after this change because it would become my-model/model.onnx/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
S3 treats
Prefixas a raw string. Withmy-model, a bucket containingmy-model/model.onnxandmy-model-backup/unrelated.binreturns bothThe second path lands outside the staging dir, pretty easy to hit in shared buckets
This adds the trailing
/for directory listings. Keys already ending in/stay unchanged.How Has This Been Tested?
Repro:
MODEL_SYNC_SOURCE_AWS_KEY=my-model.my-model/model.onnxis.Passed all 55 async upload unit tests,
make build/compile,make lint, andmake vetA real MinIO check passed too
Broad
make testwas also run, but unrelated MySQL testcontainers timed out on startupMerge criteria: