Skip to content

fix: honor cluster-domain in worker DNS search paths - #832

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
immanuwell:fix/worker-dns-cluster-domain
Jul 10, 2026
Merged

fix: honor cluster-domain in worker DNS search paths#832
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
immanuwell:fix/worker-dns-cluster-domain

Conversation

@immanuwell

Copy link
Copy Markdown
Member

small follow-up to #704 and #738.

--cluster-domain already updates the hostfile and discover_hosts.sh, but worker pods still get dnsConfig.searches hardcoded to svc.cluster.local.
That bites Intel MPI and MPICH, workers need to resolve the launcher hostname too.

Fix:

  • use the configured cluster domain when building worker DNS search suffixes
  • add a regression test for a custom-domain Intel MPI job

Repro:

  1. Start the operator with --cluster-domain=kube.local
  2. Create an Intel MPI or MPICH job
  3. Inspect a worker pod with kubectl get pod <worker> -o yaml
  4. Before this patch it has dnsConfig.searches: ["<job>.<ns>.svc.cluster.local"]
  5. The launcher FQDN is ...svc.kube.local, so hostname lookup is off and the job can break

Signed-off-by: immanuwell <pchpr.00@list.ru>
@immanuwell
immanuwell force-pushed the fix/worker-dns-cluster-domain branch from 1e0b68e to 41d0420 Compare July 10, 2026 09:33

@tenzen-y tenzen-y left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is actually bug for MPICH and Intel MPI in case of the custom domain.
Thank you!

/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
google-oss-prow Bot merged commit f5a6a66 into kubeflow:master Jul 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants