fix: add nil safety checks and immutability validation - #3864
Open
Swaraj-do wants to merge 4 commits into
Open
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
Swaraj-do
force-pushed
the
fix/runtime-nil-checks
branch
from
August 6, 2026 15:10
8f7277f to
1ce7bff
Compare
Add nil safety checks in ExtractResourcePerNodeFromRuntime and JobSet.Validate to prevent runtime panics when processing minimal or malformed ReplicatedJob specifications. Signed-off-by: Swaraj-do <swarajmohanty183@gmail.com>
Add nil runtime guard in setTrainJobStatus and preserve pre-existing status conditions set during reconciliation. Signed-off-by: Swaraj-do <swarajmohanty183@gmail.com>
Swaraj-do
force-pushed
the
fix/runtime-nil-checks
branch
from
August 6, 2026 15:18
1ce7bff to
384fc5f
Compare
Validate that Spec.RuntimeRef cannot be modified during TrainJob updates. Signed-off-by: Swaraj-do <swarajmohanty183@gmail.com>
Safely handle nil spec.trainer in validateTorchTune and getRecipeAndConfig to prevent admission webhook panics. Signed-off-by: Swaraj-do <swarajmohanty183@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR resolves several critical nil-pointer dereference vulnerabilities and enforces immutability validation across the
TrainJobcontroller, admission webhooks, and runtime plugins:ReplicatedJob & Runtime Nil Safety (
pkg/runtime&jobsetplugin):ExtractResourcePerNodeFromRuntimeandJobSet.Validateto safely handle minimal or malformedReplicatedJobspecifications without triggering controller panics.Controller Status Preservation (
pkg/controller/trainjob_controller.go):setTrainJobStatus.runtimeRefImmutability Validation (pkg/webhooks/trainjob_webhook.go):TrainJobadmission webhook ensuringspec.runtimeRefcannot be modified during updates after creation.TorchTune Plugin Guards (
pkg/runtime/framework/plugins/torch/torchtune.go):spec.trainerinsidevalidateTorchTuneandgetRecipeAndConfig, preventing admission webhook panics when trainer fields are absent.Comprehensive Unit Test Coverage:
trainjob_controller_test.go,jobset_test.go,torchtune_test.go,runtime_test.go, andtrainjob_webhook_test.goto prevent regressions.Checklist
fix: ...)go test ./pkg/...)