chore: Nominate robert-bell as Kubeflow Trainer reviewer - #3873
Conversation
3f57896 to
aa5c836
Compare
There was a problem hiding this comment.
Pull request overview
Adds Robert Bell as a Kubeflow Trainer reviewer and synchronizes generated Objective API documentation.
Changes:
- Adds
robert-bellto root reviewers. - Removes an outdated metric default claim from generated API artifacts.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
OWNERS |
Adds the nominated reviewer. |
pkg/client/applyconfiguration/trainer/v1alpha1/objective.go |
Updates generated field documentation. |
pkg/apis/trainer/v1alpha1/zz_generated.openapi.go |
Updates generated OpenAPI documentation. |
manifests/base/crds/trainer.kubeflow.org_optimizationjobs.yaml |
Synchronizes the base CRD description. |
charts/kubeflow-trainer/templates/crd/trainer.kubeflow.org_optimizationjobs.yaml |
Synchronizes the Helm CRD description. |
api/python_api/kubeflow_trainer_api/models/trainer_v1alpha1_objective.py |
Updates generated Python model documentation. |
api/openapi-spec/swagger.json |
Synchronizes the Swagger description. |
Files not reviewed (1)
- pkg/client/applyconfiguration/trainer/v1alpha1/objective.go: Generated file
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
aa5c836 to
ddbff78
Compare
astefanutti
left a comment
There was a problem hiding this comment.
+1, thanks @robert-bell for all your contributions!
tenzen-y
left a comment
There was a problem hiding this comment.
+1 ! Thank you @robert-bell for your contributions!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
I would like to nominate @robert-bell as Kubeflow Trainer reviewer 🎉
Rob was involved in Trainer development over the past 6 months and contributed many features such as TrainJob status server, snapshot, and more!
Thank you for your great work @robert-bell!
/hold for review
/assign @astefanutti @tenzen-y @akshaychitneni @kubeflow/wg-training-chairs