feat(operator): Implement OptimizationJob reconciler loop - #3878
Open
Swaraj-do wants to merge 1 commit into
Open
feat(operator): Implement OptimizationJob reconciler loop#3878Swaraj-do wants to merge 1 commit into
Swaraj-do wants to merge 1 commit into
Conversation
Implement OptimizationJobReconciler controller in pkg/controller/optimizationjob_controller.go to orchestrate hyperparameter tuning trial TrainJobs per KEP-3562 (proposals/2605-optimization-job-crd/README.md). - Add OptimizationJobReconciler controller watching OptimizationJob and owning child TrainJobs - Sample parameter values across Categorical, Uniform, and LogUniform search spaces - Inject hyperparameter environment variables (KUBEFLOW_TRAINER_OPT_<NAME>) into TrainJob trainer specs and metadata annotations - Enforce parallelTrials concurrency limits and numTrials total trial limits - Update status conditions (Created, Complete, Failed) and record best trial parameters in status.result - Register reconciler in SetupControllers in setup.go - Add unit tests in pkg/controller/optimizationjob_controller_test.go Fixes kubeflow#3877 Signed-off-by: Swaraj-do <swarajmohanty183@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR implements the OptimizationJobReconciler controller in pkg/controller/optimizationjob_controller.go to orchestrate hyperparameter tuning trial TrainJobs per KEP-3562 (https://github.com/kubeflow/trainer/blob/master/proposals/2605-optimization-job-crd/README.md).
Key Features Implemented
Which issue(s) this PR fixes
Fixes #3877
Checklist