fix(operator): apply configured health probe endpoint names - #3886
Open
rjgoyln wants to merge 1 commit into
Open
fix(operator): apply configured health probe endpoint names#3886rjgoyln wants to merge 1 commit into
rjgoyln wants to merge 1 commit into
Conversation
The config API, the base manifests, and the Helm chart all expose readinessEndpointName and livenessEndpointName, but the manager never received them, so the probes stayed on controller-runtime's own /readyz and /healthz. A deployment that renamed an endpoint and pointed its probe at the new path got a 404 back and a container that never turned ready. Every place these names are configured spells them without a leading slash, while controller-runtime registers them as http.ServeMux patterns, which panic on a pattern that has none. They are rooted on the way through so the shipped defaults keep serving where the probes already look, and the startup log now reports the paths that were registered rather than the two it assumed. Signed-off-by: rjgoyln <pt40419@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readinessEndpointNameandlivenessEndpointNamehave been exposed in the config API and Helm chart with defaults, but were never passed to the manager. As a result, probes always used controller-runtime's default/readyzand/healthzendpoints. Renaming an endpoint and updating the Deployment probe therefore caused 404s and left the container permanently unready.The configured names are now passed to the manager. Because the config values omit the leading
/(for example,readinessEndpointName: readyz) whilehttp.ServeMuxpatterns require one, the endpoints are normalized before registration. This preserves the existing defaults while allowing custom endpoint names.Invalid endpoint names that
ServeMuxrejects now fail at startup instead of being silently ignored. Validation in the config layer remains unchanged.Tests
The
Loadcases and endpoint normalization test both fail without the change.