docs: use podProtections args in helm chart #1765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
size/S
googs1025
changed the title
ingvagabund
reviewed
Oct 27, 2025
charts/descheduler/values.yaml
Outdated
|
|
||
|
|
||
| # Mount the ServiceAccountToken in the Pod of a CronJob or Deployment | ||
|
|
Contributor
There was a problem hiding this comment.
nit: this NL can be dropped.
Signed-off-by: googs1025 <[email protected]>
Contributor
|
/approve |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Oct 31, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://github.com/kubernetes-sigs/descheduler) | minor | `0.33.0` -> `0.34.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.34.0`](https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.34.0): Descheduler v0.34.0 [Compare Source](kubernetes-sigs/descheduler@v0.33.0...v0.34.0) #### What's Changed - Remove reference to obsolete deschedulerPolicy fields in chart values by [@​meroupatate](https://github.com/meroupatate) in [#​1674](kubernetes-sigs/descheduler#1674) - v0.33.0: bump helm chart by [@​a7i](https://github.com/a7i) in [#​1680](kubernetes-sigs/descheduler#1680) - optimize: NodeFit function by reordering checks for performance by [@​googs1025](https://github.com/googs1025) in [#​1681](kubernetes-sigs/descheduler#1681) - feature: sort pods by restarts count in RemovePodsHavingTooManyRestarts plugin by [@​googs1025](https://github.com/googs1025) in [#​1686](kubernetes-sigs/descheduler#1686) - chore: move namespaces filtering logic to New() by [@​googs1025](https://github.com/googs1025) in [#​1684](kubernetes-sigs/descheduler#1684) - RemovePodsViolatingNodeTaints: list only pods that are not failed/suceeded by [@​ingvagabund](https://github.com/ingvagabund) in [#​1688](kubernetes-sigs/descheduler#1688) - fix(example): list only active pod by [@​googs1025](https://github.com/googs1025) in [#​1691](kubernetes-sigs/descheduler#1691) - refactor: separate eviction constraints to constraints.go by [@​googs1025](https://github.com/googs1025) in [#​1693](kubernetes-sigs/descheduler#1693) - Extend plugin's New with a context.Context by [@​ingvagabund](https://github.com/ingvagabund) in [#​1694](kubernetes-sigs/descheduler#1694) - \*1677 Allow Succeeded and Failed states in PodLifeTime by [@​doctapp](https://github.com/doctapp) in [#​1696](kubernetes-sigs/descheduler#1696) - metrics name refact by [@​lowang-bh](https://github.com/lowang-bh) in [#​1232](kubernetes-sigs/descheduler#1232) - feat(prometheus): allow different url schemes by [@​ricardomaraschini](https://github.com/ricardomaraschini) in [#​1705](kubernetes-sigs/descheduler#1705) - feature: use contextal logging for plugins by [@​googs1025](https://github.com/googs1025) in [#​1655](kubernetes-sigs/descheduler#1655) - logger: Align with the previous logger verbosity by [@​ingvagabund](https://github.com/ingvagabund) in [#​1708](kubernetes-sigs/descheduler#1708) - add activeDeadlineSeconds field for cronjob by [@​googs1025](https://github.com/googs1025) in [#​1709](kubernetes-sigs/descheduler#1709) - chore: stop with no-op default evictor settings by [@​ricardomaraschini](https://github.com/ricardomaraschini) in [#​1717](kubernetes-sigs/descheduler#1717) - fix: removepodsviolatingtopologyspreadconstraint to favor evictable pods when balancing domains by [@​a7i](https://github.com/a7i) in [#​1719](kubernetes-sigs/descheduler#1719) - fix: Fix panic in descheduler when using `--secure-port=0` by [@​dongjiang1989](https://github.com/dongjiang1989) in [#​1647](kubernetes-sigs/descheduler#1647) - feat(helm): run descedulerPolicy thru tpl func for more chart control by [@​schahal](https://github.com/schahal) in [#​1660](kubernetes-sigs/descheduler#1660) - Test code refactorings by [@​ingvagabund](https://github.com/ingvagabund) in [#​1722](kubernetes-sigs/descheduler#1722) - Default evictor no eviction policy by [@​ingvagabund](https://github.com/ingvagabund) in [#​1723](kubernetes-sigs/descheduler#1723) - add PodProtections for DefaultEvictorArgs by [@​googs1025](https://github.com/googs1025) in [#​1665](kubernetes-sigs/descheduler#1665) - add ValidateHighNodeUtilizationPluginConfig unit test by [@​googs1025](https://github.com/googs1025) in [#​1733](kubernetes-sigs/descheduler#1733) - feature: add PodsWithResourceClaims parameter in DefaultEvictorArgs PodProtections by [@​googs1025](https://github.com/googs1025) in [#​1603](kubernetes-sigs/descheduler#1603) - update readme for PodProtections by [@​googs1025](https://github.com/googs1025) in [#​1728](kubernetes-sigs/descheduler#1728) - Improves the validation logic in the plugins by [@​googs1025](https://github.com/googs1025) in [#​1729](kubernetes-sigs/descheduler#1729) - feat(token): automountServiceAccountToken set hard to true on deployment by [@​jmederer](https://github.com/jmederer) in [#​1641](kubernetes-sigs/descheduler#1641) - standardize protectionEnabled param across eviction constraints by [@​googs1025](https://github.com/googs1025) in [#​1725](kubernetes-sigs/descheduler#1725) - \[1732] chore: add cronjob/job labels and annotations to helm chart by [@​n2h9](https://github.com/n2h9) in [#​1736](kubernetes-sigs/descheduler#1736) - chore: add pull request template by [@​ricardomaraschini](https://github.com/ricardomaraschini) in [#​1742](kubernetes-sigs/descheduler#1742) - feat(test/e2e): introduce new flags to override RunAsUser and RunAsGroup security context setting by [@​ingvagabund](https://github.com/ingvagabund) in [#​1743](kubernetes-sigs/descheduler#1743) - helm chart - Allow to add custom annotations for deployment by [@​anthosz](https://github.com/anthosz) in [#​1741](kubernetes-sigs/descheduler#1741) - chore: give tracing.Shutdown() its own context by [@​ricardomaraschini](https://github.com/ricardomaraschini) in [#​1747](kubernetes-sigs/descheduler#1747) - fix: correct comment for HaveNoEvictionAnnotation by [@​eminaktas](https://github.com/eminaktas) in [#​1746](kubernetes-sigs/descheduler#1746) - descheduler: handle single-node clusters gracefully by [@​tsj-30](https://github.com/tsj-30) in [#​1755](kubernetes-sigs/descheduler#1755) - feat(eviction): add annotations to eviction requests for observability by [@​tiraboschi](https://github.com/tiraboschi) in [#​1753](kubernetes-sigs/descheduler#1753) - test: run by default with kind 0.30.0 and kubevirt v1.6.2 by [@​tiraboschi](https://github.com/tiraboschi) in [#​1762](kubernetes-sigs/descheduler#1762) - \[v0.34.0] bump to kubernetes 1.34 deps by [@​a7i](https://github.com/a7i) in [#​1744](kubernetes-sigs/descheduler#1744) - chore: update approvers by [@​ricardomaraschini](https://github.com/ricardomaraschini) in [#​1759](kubernetes-sigs/descheduler#1759) - helm: Fix liveness probe timeout for descheduler chart by [@​rstribrn](https://github.com/rstribrn) in [#​1751](kubernetes-sigs/descheduler#1751) - docs: use podProtections args in helm chart by [@​googs1025](https://github.com/googs1025) in [#​1765](kubernetes-sigs/descheduler#1765) - \[v0.34.0] update docs and manifests by [@​a7i](https://github.com/a7i) in [#​1768](kubernetes-sigs/descheduler#1768) #### New Contributors - [@​meroupatate](https://github.com/meroupatate) made their first contribution in [#​1674](kubernetes-sigs/descheduler#1674) - [@​doctapp](https://github.com/doctapp) made their first contribution in [#​1696](kubernetes-sigs/descheduler#1696) - [@​lowang-bh](https://github.com/lowang-bh) made their first contribution in [#​1232](kubernetes-sigs/descheduler#1232) - [@​schahal](https://github.com/schahal) made their first contribution in [#​1660](kubernetes-sigs/descheduler#1660) - [@​jmederer](https://github.com/jmederer) made their first contribution in [#​1641](kubernetes-sigs/descheduler#1641) - [@​n2h9](https://github.com/n2h9) made their first contribution in [#​1736](kubernetes-sigs/descheduler#1736) - [@​anthosz](https://github.com/anthosz) made their first contribution in [#​1741](kubernetes-sigs/descheduler#1741) - [@​tsj-30](https://github.com/tsj-30) made their first contribution in [#​1755](kubernetes-sigs/descheduler#1755) - [@​tiraboschi](https://github.com/tiraboschi) made their first contribution in [#​1753](kubernetes-sigs/descheduler#1753) - [@​rstribrn](https://github.com/rstribrn) made their first contribution in [#​1751](kubernetes-sigs/descheduler#1751) **Full Changelog**: <kubernetes-sigs/descheduler@v0.33.0...v0.34.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNTUuNCIsInVwZGF0ZWRJblZlciI6IjQxLjE1NS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJjaGFydCJdfQ==--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1914 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Please ensure your pull request meets the following criteria before submitting
for review, these items will be used by reviewers to assess the quality and
completeness of your changes:
we already use podProtections in this pr #1665 and mark other similar args as Deprecated
use podProtections args instead of
ignorePvcPodsandevictLocalStoragePodsin helm chartCode Readability: Is the code easy to understand, well-structured, and consistent with project conventions?
Naming Conventions: Are variable, function, and structs descriptive and consistent?
Code Duplication: Is there any repeated code that should be refactored?
Function/Method Size: Are functions/methods short and focused on a single task?
Comments & Documentation: Are comments clear, useful, and not excessive? Were comments updated where necessary?
Error Handling: Are errors handled appropriately ?
Testing: Are there sufficient unit/integration tests?
Performance: Are there any obvious performance issues or unnecessary computations?
Dependencies: Are new dependencies justified ?
Logging & Monitoring: Is logging used appropriately (not too verbose, not too silent)?
Backward Compatibility: Does this change break any existing functionality or APIs?
Resource Management: Are resources (files, connections, memory) managed and released properly?
PR Description: Is the PR description clear, providing enough context and explaining the motivation for the change?
Documentation & Changelog: Are README and docs updated if necessary?