Skip to content

feat: add node_readiness_rules with enforcement_mode and dry_run labels - #448

Open
rawadhossain wants to merge 1 commit into
kubernetes-sigs:mainfrom
rawadhossain:readiness-rules
Open

feat: add node_readiness_rules with enforcement_mode and dry_run labels#448
rawadhossain wants to merge 1 commit into
kubernetes-sigs:mainfrom
rawadhossain:readiness-rules

Conversation

@rawadhossain

@rawadhossain rawadhossain commented Aug 24, 2026

Copy link
Copy Markdown
Member

Description

  • Adds node_readiness_rules{enforcement_mode, dry_run} while keeping node_readiness_rules_total unchanged for compatibility.
  • Updates the metric from the rule cache on rule create, update, and delete.
  • Updates monitoring.md and docs/TEST_README.md.
  • Adds related tests, also contributes to testing: Add Test Coverage for Prometheus Metrics #269.

from the design doc:

image image

Related to #446

Type of Change

/kind feature

Testing

make test, make lint, go vet, gofmt -l all pass.

Checklist

  • make test passes
  • make lint passes

Signed-off-by: Rawad Hossain <rawad.hossain00@gmail.com>
@kubernetes-prow kubernetes-prow Bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 24, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rawadhossain
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow
kubernetes-prow Bot requested review from mrunalp and tallclair August 24, 2026 08:19
@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2026
@netlify

netlify Bot commented Aug 24, 2026

Copy link
Copy Markdown

Deploy Preview for node-readiness-controller ready!

Name Link
🔨 Latest commit 58c5646
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6a8bfe8ec782d50008339d70
😎 Deploy Preview https://deploy-preview-448--node-readiness-controller.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow

Copy link
Copy Markdown

Hi @rawadhossain. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 24, 2026
@rawadhossain

Copy link
Copy Markdown
Member Author

/cc @ajaysundark

@kubernetes-prow
kubernetes-prow Bot requested a review from ajaysundark August 26, 2026 08:19
@rawadhossain

Copy link
Copy Markdown
Member Author

/cc @AvineshTripathi

@AvineshTripathi

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2026
@rawadhossain

Copy link
Copy Markdown
Member Author

/retest

@AvineshTripathi AvineshTripathi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're already calling ListRules in the collector, we can compute the enforcement_mode/dry_run breakdown there instead of maintaining a separate in-memory sync. The local ruleCache can lag behind actual cluster state and can be unreliable.

cc @ajaysundark wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants