kvm2: Set group executable bit on machine-specific directory and up#2293
Merged
dlorenc merged 1 commit intoDec 11, 2017
Merged
Conversation
Ensure that the directories leading to the KVM image have enough permission for libvirt/QEMU to traverse, especially in the case where libvirt/QEMU group is set to to `kvm`/`users`.
k8s-ci-robot
added
the
size/XS
Contributor
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
Collaborator
|
Can one of the admins verify this patch? |
Contributor
Author
|
Bump to verify CLA. |
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
@minikube-bot ok to test |
Contributor
Author
|
Thank you too! 🎉 |
zakame
deleted the
kvm-driver-set-group-executable-bit-on-machine-dir
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the directories leading to the KVM image have enough
permission for libvirt/QEMU to traverse, especially in the case where
libvirt/QEMU group is set to to kvm/users.
This is a port of dhiltgen/docker-machine-kvm#51
to the kvm2 driver. See also
dhiltgen/docker-machine-kvm#46.