refactor: update toolchain-common with renamed ServerSideApplyClient type

[xcoulon]

fix golangci-lint issues: in particular, use os.Root to avoid Time-of-Check-Time-of-Use (TOCTOU) race condition with symlinks in filepath.Walk/filepath.WalkDir callbacks

also, update the golangci-lint-action settings

Signed-off-by: Xavier Coulon xcoulon@redhat.com

[MatousJobanek]

interesting problem with the TOCTOU - Personally, it would be completely OK to ignore the linter error here (and keep it simple) because there is technically zero risk of facing this issue with ksctl. But feel free to keep it as it is.

[xcoulon]

interesting problem with the TOCTOU - Personally, it would be completely OK to ignore the linter error here (and keep it simple) because there is technically zero risk of facing this issue with ksctl. But feel free to keep it as it is.

makes sense, I've reverted the changes in 315f961

[codecov]

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 59.90%. Comparing base (11bbefd) to head (e0d88ad).

Files with missing lines	Patch %	Lines
pkg/cmd/adm/install_operator.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   59.90%   59.90%           
=======================================
  Files          56       56           
  Lines        3257     3257           
=======================================
  Hits         1951     1951           
  Misses       1085     1085           
  Partials      221      221           

Files with missing lines	Coverage Δ
pkg/cmd/add_space_users.go	76.92% <100.00%> (ø)
pkg/cmd/generate/nstemplatetiers.go	55.35% <100.00%> (ø)
pkg/cmd/adm/install_operator.go	77.50% <66.66%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.