Skip to content

Conversation

@bvolovat
Copy link
Contributor

@bvolovat bvolovat commented Feb 3, 2026

Summary by CodeRabbit

  • Tests
    • Extended E2E test dispatch to include HTTP request component testing.
    • Added Node Agent end-to-end testing coverage.
    • Added Storage end-to-end testing coverage.

@bvolovat bvolovat requested a review from Naor-Armo February 3, 2026 10:36
@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Adds three new cases to the E2E workflow dispatch switch, mapping component names http-request, nodeAgent, and storage to HTTP_REQUEST, NODE_AGENT_E2E, and STORAGE_E2E test groups respectively in the GitHub Actions workflow.

Changes

Cohort / File(s) Summary
Workflow Dispatch Configuration
.github/workflows/incluster-comp-pr-merged.yaml
Added three new switch branches to map http-requestHTTP_REQUEST, nodeAgentNODE_AGENT_E2E, and storageSTORAGE_E2E for E2E test dispatching.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • kubescape/workflows#76 — Modifies the same E2E dispatch mapping logic in .github/workflows/incluster-comp-pr-merged.yaml; closely related changes to component→TESTS_GROUP mapping.

Suggested reviewers

  • Naor-Armo

Poem

🐰
I hopped through lines of YAML bright,
Added cases, three took flight,
HTTP, Node Agent, Storage too,
Now dispatch knows just what to do,
Hooray — a hop, a skip, a light delight!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'remove empty groups test' does not match the actual changes, which add three new test case mappings (http-request, nodeAgent, storage) to dispatch logic. Update the title to accurately reflect the main changes, such as 'Add HTTP_REQUEST, NODE_AGENT_E2E, and STORAGE_E2E test group mappings' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch run_test_from_private_repo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

Naor-Armo
Naor-Armo previously approved these changes Feb 3, 2026
@matthyx matthyx moved this to Waiting on Author in KS PRs tracking Feb 3, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: failure

@bvolovat bvolovat merged commit b85b639 into main Feb 3, 2026
10 of 11 checks passed
@matthyx matthyx moved this from Waiting on Author to To Archive in KS PRs tracking Feb 3, 2026
@coderabbitai coderabbitai bot mentioned this pull request Feb 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants