Skip to content

Feat(numa cpu pressure eviction config) add reclaim eviction feature - #212

Merged
cheney-lin merged 1 commit into
kubewharf:mainfrom
chuyingzhi:feat(NumaCPUPressureEvictionConfig)--add-upper-and-lower-bound
Jul 29, 2026
Merged

Feat(numa cpu pressure eviction config) add reclaim eviction feature#212
cheney-lin merged 1 commit into
kubewharf:mainfrom
chuyingzhi:feat(NumaCPUPressureEvictionConfig)--add-upper-and-lower-bound

Conversation

@chuyingzhi

@chuyingzhi chuyingzhi commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

What type of PR is this?

What this PR does / why we need it:

add reclaim eviction feature

Which issue(s) this PR fixes:

Special notes for your reviewer:

Summary by CodeRabbit

  • New Features
    • Added configurable reclaim eviction for NUMA-level CPU pressure.
    • Added a CPU usage threshold to trigger reclaim eviction.
    • Added namespace-based priority ordering for selecting eviction targets.
    • Updated configuration schemas to support the new options.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@chuyingzhi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 38 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a70116b4-8519-4bca-b0c0-50c9593701e1

📥 Commits

Reviewing files that changed from the base of the PR and between 910a6f9 and 0cfd038.

📒 Files selected for processing (3)
  • config/crd/bases/config.katalyst.kubewharf.io_adminqosconfigurations.yaml
  • pkg/apis/config/v1alpha1/adminqos.go
  • pkg/apis/config/v1alpha1/zz_generated.deepcopy.go
📝 Walkthrough

Walkthrough

NUMA CPU pressure eviction configuration now supports a reclaim eviction tier with an enable flag, CPU usage threshold, and namespace priority list. The API type, CRD schema, and generated deep-copy logic include these fields.

Changes

NUMA reclaim eviction configuration

Layer / File(s) Summary
Reclaim eviction configuration contract
pkg/apis/config/v1alpha1/adminqos.go, config/crd/bases/config.katalyst.kubewharf.io_adminqosconfigurations.yaml
Adds reclaim eviction enablement, a bounded CPU usage threshold, and ordered namespace priorities to the API type and CRD schema.
Deep-copy support
pkg/apis/config/v1alpha1/zz_generated.deepcopy.go
Deep-copies the new optional boolean, float pointer, and namespace slice fields.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: cheney-lin

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a reclaim eviction feature to NUMA CPU pressure eviction config.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chuyingzhi
chuyingzhi force-pushed the feat(NumaCPUPressureEvictionConfig)--add-upper-and-lower-bound branch 2 times, most recently from 1434aa2 to 910a6f9 Compare July 29, 2026 06:41
@chuyingzhi
chuyingzhi marked this pull request as ready for review July 29, 2026 06:42
@chuyingzhi
chuyingzhi force-pushed the feat(NumaCPUPressureEvictionConfig)--add-upper-and-lower-bound branch from 910a6f9 to 0cfd038 Compare July 29, 2026 07:04
@cheney-lin
cheney-lin merged commit 7cfdfb9 into kubewharf:main Jul 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants