fix(setup): guard known affected ublk kernels - #93
Open
catyans wants to merge 5 commits into
Open
Conversation
Contributor
|
✅ OpenCodeReview: No comments generated. Looks good to me. |
Signed-off-by: Yanshu WANG <wangyanshu2016@gmail.com>
Signed-off-by: Yanshu WANG <wangyanshu2016@gmail.com>
Author
|
Addressed the latest suffix-matching review and completed an independent Linux validation on head
The targeted cases include Azure kernel releases with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to contain the
ADD_DEVinitialization regressionreleases recorded in AgentENV fails on kernels affected by the ublk ADD_DEV initialization regression #20
prerequisite commit
011af85ccd87ADD_DEVis unsafeWhy
On an affected kernel, the first
UBLK_U_CMD_ADD_DEVcan hang and trigger akernel NULL-pointer dereference. Waiting for device creation to fail is
therefore not a safe compatibility probe.
This change checks the running release before AgentENV enters the ublk path and
returns an actionable error. The guard is intentionally limited to releases
known to be affected. Operators whose vendor kernel has backported the
prerequisite fix can set:
The override emits a warning and only bypasses the release check; it does not
claim to work around the kernel defect.
Validation
5.10.134-16.3.al8.x86_64):cargo fmt --all -- --checkcargo test -p agentenv setup::ublk::tests -- --nocapture(3 passed)cargo fmt --all -- --checkfalse-positive release strings
1ortruegit diff --checkCloses #20.