Update banner.js - #2
Open
YashSharma64 wants to merge 1 commit into
Open
Conversation
-Idempotent Banner Injection: Checks if the file already has a banner (/*! or /**) to prevent duplicates. -Async / Non-blocking I/O: Uses fs.promises for modern, asynchronous file operations. -Atomic Write: Writes to a temporary file first, then renames it to avoid corruption or partial writes. -Preserves File Metadata: Attempts to retain original file permissions and timestamps. -Robust Path Handling: Supports optional file argument and resolves package.json reliably. -Better Error Handling: Exits with a non-zero code if an error occurs, making it CI-friendly. -Future-proof / Maintainable: Clean, readable, and structured for easy updates or integration into npm scripts or CI pipelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Idempotent Banner Injection: Checks if the file already has a banner (/*! or /**) to prevent duplicates.
-Async / Non-blocking I/O: Uses fs.promises for modern, asynchronous file operations.
-Atomic Write: Writes to a temporary file first, then renames it to avoid corruption or partial writes.
-Preserves File Metadata: Attempts to retain original file permissions and timestamps.
-Robust Path Handling: Supports optional file argument and resolves package.json reliably.
-Better Error Handling: Exits with a non-zero code if an error occurs, making it CI-friendly.
-Future-proof / Maintainable: Clean, readable, and structured for easy updates or integration into npm scripts or CI pipelines.