feat: refactor s6 startup service
#73
Open
+59
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yun Pan <[email protected]>
Signed-off-by: Yun Pan <[email protected]>
dinoallo
changed the title
startup service
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the s6 startup service to improve modularity by extracting inline startup logic into individual executable scripts that run in a deterministic order. The new architecture delegates to a handler script that discovers and executes startup scripts from a designated directory.
- Introduced modular startup handler that executes scripts from a directory in lexical order
- Extracted hostname and pod ID setup logic into separate numbered startup scripts
- Updated configuration to copy startup scripts and delegate to the new handler
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
experimental/base-tools/scripts/svc/handle-startup.sh |
New handler that discovers and executes startup scripts sequentially from STARTUP_SCRIPTS_DIR |
experimental/base-tools/scripts/svc/configure-startup.sh |
Updated to copy startup scripts to the target directory and delegate execution to the handler |
experimental/base-tools/scripts/svc/startup/00-set-hostname.sh |
New modular script that sets the container hostname from environment variable |
experimental/base-tools/scripts/svc/startup/01-set-pod-id.sh |
New modular script that writes pod UID to a file for runtime reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Yun Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the container startup process to make it more modular and maintainable by moving startup logic into individual scripts that are executed in order. The main script now delegates to a new handler, which runs all executable scripts in a designated directory. This allows for easier customization and extension of startup behavior.
Key changes include:
Startup Process Refactoring:
handle-startup.sh, which runs all executable scripts in theSTARTUP_SCRIPTS_DIRdirectory in lexical order, ensuring deterministic and modular startup behavior. The handler safely exits if no scripts are present.configure-startup.shto copy all scripts fromstartup/into the startup scripts directory and delegate execution tohandle-startup.shinstead of embedding logic directly.New Modular Startup Scripts:
00-set-hostname.shto set the container's hostname from theSEALOS_DEVBOX_NAMEenvironment variable, if provided.01-set-pod-id.shto write the pod UID to a file if theSEALOS_DEVBOX_POD_UIDenvironment variable is set.