Prepare v1 release #87
Conversation
…t_cache unit tests
…t_cache integeration tests
|
get_relevant_documents is deprecated for invoke method (this was being called in get_relevant documents anyway) |
| langchain = ">=0.3.10,<1.0.0" | ||
| langchain = ">=0.3.10" | ||
| aiohttp = "^3.8.3" | ||
| langchain-classic = "^1.0.0" |
There was a problem hiding this comment.
I find it strange that we have a mix of langchain dependencies here, some at 0.3 and some at 1.0. If we intend for this 1.0 release to also support langchain 0.3, then we should have tests in place that ensure everything works. Or if we decide that we only support langchain 1.0 and up, then the 0.3 references should be upgraded.
Also, doesn't langchain-classic need to be given as a general dependency? You have it in the testing section right now, but you are importing from this package in the code.
Finally, the documentation for the langchain-classic package says this:
Legacy chains, langchain-community re-exports, indexing API, deprecated functionality, and more. In most cases, you should be using the main langchain package."
Have you looked into upgrading our implementation so that we can use the proper interfaces in langchain instead of the legacy or deprecated ones?
There was a problem hiding this comment.
I will look into your feedback, thank you for it. For the latter part, Could you tell me where you got that quote about the langchain-classic package? The migration docs says the main Lang chain package is now concerned with agents https://docs.langchain.com/oss/python/migrate/langchain-v1
The langchain package namespace has been significantly reduced in v1 to focus on essential building blocks for agents. The streamlined package makes it easier to discover and use the core functionality.
They also say
langchain-classic
If you were using any of the following from the langchain package, you’ll need to install langchain-classic and update your imports:
There was a problem hiding this comment.
It's on their readme file in the "What is this?" section: https://github.com/langchain-ai/langchain/tree/master/libs/langchain#-what-is-this
|
check if we use langchain still |
ssh-esh
force-pushed
the
upgrade-to-v1
branch
from
4076e57 to
282452e
Compare
|
hey hello, any timelines on this? |
3 participants
Closes https://github.com/elastic/devtools-integrations/issues/53