Repository navigation
fix(hook): ignore typed non-chat rows that carry a chat role - #108
Merged
Merged
Conversation
Claude Code now writes request records (type "api-request-blob") whose nested message has role user or assistant but no timestamp. The role fallback read them as chat rows: a user-role blob became the turn's prompt, so the root span started at hook time and ended before it started, and an assistant-role blob added a model-less "LLM Call". Only untyped rows fall back to message.role now.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent Claude Code versions write
api-request-blobtranscript rows. These are request records whose nestedmessage.roleisuserorassistant, and they have no timestamp. The role fallback read them as chat rows.What this broke, seen on a self-hosted Langfuse 4.38:
/usagecaveat).LLM Callthat copied the previous reply.Fix: only untyped rows fall back to
message.role.Testing
tests/integration/test_state_lock_contention.py::test_entry_of_another_session_survives_the_emit, also fails onmainwithout this change.ruff check --select F,E9is clean.claude -pand ACP: sequential tools, multi-turn, parallel and nested subagents, MCP failures, background agents, slash commands, an API-error final turn, SIGTERM, and kill-and-resume. 8/8 pass with the fix; 0/8 passed before.