Feature/close diagnostic loop #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owal7428
force-pushed
the
feature/close-diagnostic-loop
branch
from
1f35499 to
9c5bb5e
Compare
owal7428
force-pushed
the
feature/close-diagnostic-loop
branch
from
9c5bb5e to
dbe0d07
Compare
thibaudteil
approved these changes
Nov 25, 2025
patkenneally
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated protobufs and hooked protobuf parameters into diagnostics pipeline. Also changed the interface such that the diagnostic protobuf is sent directly over ZMQ instead of individual diagnostics.Verification
Added a pytest test that checks for correct coverage percentage for varying boundary box sizes.Documentation
NoneFuture work
None