fix: replace bare except with except Exception in open_las#369
Open
AmSach wants to merge 1 commit into
Open
Conversation
Bare except clauses catch all exceptions including BaseException-derived classes like KeyboardInterrupt and SystemExit, which can prevent clean program termination. Replacing with 'except Exception' makes the intent explicit (catch application errors only) and matches the pattern used elsewhere in the codebase (lasreader.py, laswriter.py, lasappender.py).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces 3 bare
except:clauses inlaspy/lib.py'sopen_las()function withexcept Exception:.Why
Bare
except:clauses catch all exceptions, includingBaseException-derived classes likeKeyboardInterruptandSystemExit. This can:The intent of the existing code is clear: if the
LasReader/LasWriter/LasAppenderconstructor fails, close the stream and re-raise. This is application-level error handling, soExceptionis the right base class.Pattern Consistency
This also matches the existing pattern used throughout the codebase:
laspy/lasreader.py:except Exception as e:laspy/laswriter.py:except Exception as e:laspy/lasappender.py:except Exception as e:Diff
(3 occurrences, in the
r,w, andamode branches)— Sent via @AmSach bot