Skip to content

Stabilize public heading typography - #221

Merged
lastobelus merged 3 commits into
t3code/refresh-ui-docs-mediafrom
t3code/public-hero-two-line
Aug 31, 2026
Merged

lastobelus merged 3 commits into
t3code/refresh-ui-docs-mediafrom
t3code/public-hero-two-line

Conversation

@lastobelus

@lastobelus lastobelus commented Aug 30, 2026 •

Copy link
Copy Markdown
Owner

Outcome

Restores the intended lighter public heading hierarchy and keeps the home-page hero on exactly two lines at every supported responsive width.

Stack

Included

  • Explicit 600 weight for public H1/H2 headings instead of browser-default 700.
  • Container-relative hero type scaling so each forced sentence line fits its actual column.
  • A non-wrapping line contract that preserves the existing intentional line break.
  • A smooth one-column type size through the existing 720px breakpoint.
  • Focused source assertions for the heading-weight and responsive contracts.

Boundary

This PR changes only public H1/H2 weight, home-page hero sizing, and their focused tests. It does not change Fable's copy, heading hierarchy, other typography, product UI, media, theme colors, or breakpoints.

Validation

  • Every H1 and H2 on the home page and all six documentation pages computes to font-weight: 600.
  • Browser-computed hero verification passed at 25 widths from 320px through 1440px, including both sides of the 360, 480, 620, 720, 900, and 1040px breakpoints.
  • Every tested width produced exactly two hero line boxes and no heading or page overflow.
  • Focused Pages tests: 18/18 pass.
  • Full local CI: 934/934 tests pass, including packaged/native smoke.
  • GitHub Verify (Node 24) passes.
  • git diff --check passes.

Child of #220 and #205.

@lastobelus

lastobelus commented Aug 30, 2026 •

Copy link
Copy Markdown
Owner Author

Work intent

phase: review
summary: "Public H1/H2 headings now compute to 600 and the hero remains exactly two lines across the finite responsive matrix; all checks pass."
touch-points:
  - docs/user/styles.css
  - test/docs-site.test.ts
done-when:
  - "The existing intentional hero break produces exactly two rendered line boxes with neither sentence wrapping."
  - "The hero H1 and public H2 headings compute to font-weight 600 rather than the browser-default 700."
  - "Rendered hero checks pass at the minimum supported 320px width, the annotated 375px width, every CSS breakpoint on both sides, and representative desktop widths through 1440px."
  - "Heading-weight checks cover the home page and every public documentation page."
  - "Focused Pages tests, full ci:local, GitHub CI, and git diff --check pass."
excludes:
  - "Changing Fable's copy, heading hierarchy, or typography outside public H1/H2 headings."
  - "Changing product UI, media, theme colors, or responsive layout breakpoints."
  - "Compatibility fallbacks for browsers outside the focused preview's current macOS support."
blocked-by:
  - "#220"
may-block:
  - "#205"
branch: "t3code/public-hero-two-line"

Completion: Completed with a clean exact-head review. Final head 1f0bf34 passed 935 tests and the packaged smoke test; it was squash-merged as 679d74d. The accepted two-line hero and 600-weight H1/H2 contract were preserved through the restack.

@lastobelus lastobelus changed the title Keep the public hero on two lines Stabilize public heading typography Aug 30, 2026
@lastobelus
lastobelus force-pushed the t3code/fable-public-copy-polish branch from e4f3675 to 60603d0 Compare August 31, 2026 00:13
@lastobelus
lastobelus force-pushed the t3code/public-hero-two-line branch from 512e8bb to 1f0bf34 Compare August 31, 2026 00:42
@lastobelus
lastobelus changed the base branch from t3code/fable-public-copy-polish to t3code/refresh-ui-docs-media August 31, 2026 00:42
@lastobelus
lastobelus marked this pull request as ready for review August 31, 2026 00:42
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-08-31T00:44:49.585528Z 1f0bf34 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lastobelus
lastobelus merged commit 679d74d into t3code/refresh-ui-docs-media Aug 31, 2026
1 of 2 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Markover Announcement Readiness Aug 31, 2026
lastobelus added a commit that referenced this pull request Aug 31, 2026
* stabilize the public hero heading

* smooth the hero type breakpoint

* restore lighter public heading weights
lastobelus added a commit that referenced this pull request Aug 31, 2026
* docs: plan Ember Light visual refresh

* docs: align visual refresh plan with design brief

* Stage sanitized public capture state (#210)

* docs: define public capture contract

* feat: stage sanitized public capture state

* test: satisfy capture staging quality gates

* Restyle public surfaces for Ember Light (#212)

* style: align public tokens with Ember Light

* docs: redraw current public product surfaces

* use canonical public app branding

* Recapture the current Ember Light product UI (#213)

* docs: reserve one strongest product capture

* docs: automate current product stills

* fix: target the packaged capture renderer

* fix: settle captures after hidden toasts

* docs: replace product captures with Ember Light

* fix: retain capture provenance after restack

* Publish the preview demo and launch assets (#214)

* chore: start demo and launch assets slice

* docs: automate the focused preview demo

* docs: show opening the captured review

* docs: publish the focused preview demo

* docs: finish the focused preview launch assets

* test: tighten launch asset assertions

* polish public preview typography

* fix: retain demo capture provenance after restack

* fix: identify Claude Code host examples

* fix: use accessible public counter color

* fix: reserve Ember orange for non-text accents

* fix: carry preview boundary on demo end card

* fix: activate unrecorded demo setup directly

* docs: regenerate demo with preview boundary

* Add Ember Dark to the public site (#217)

* add Ember Dark public appearance

* match public dark mode to Ember Dark

* refine the public site at phone widths

* stabilize the responsive footer

* keep dark accents readable

* keep dark button borders semantic

* keep dark dialog and sidebar controls usable

* collapse public navigation before controls crowd

* Polish focused-preview public copy (#220)

* polish public preview copy

* align public copy assertions

* restore canonical and pane terminology

* keep agent and privacy copy contract-accurate

* narrow every local-data promise

* Stabilize public heading typography (#221)

* stabilize the public hero heading

* smooth the hero type breakpoint

* restore lighter public heading weights

* recapture stills from a retained source

* recapture demo from a retained source

* keep brand assets legible in Ember Dark

* keep the mobile disclosure readable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant