feat(home): remove CATEGORIES breakdown card (#107)#114
Conversation
The home screen's CATEGORIES card listed each category with a count and a week-over-week percentage trend (↑ 200%, ↓ 100%, new). Those up/down deltas frame the week as a score against last week — a comparison/performance lens DESIGN.md's north star explicitly avoids (self-affirmation, never KPI guilt or comparison). A '↓ 100%' on a category you simply didn't touch reads as 'you fell off'. Removing the card keeps the home screen quiet. - Remove <CategoryFilterChips /> from TodoList right column + its import - Delete CategoryFilterChips.tsx (only consumer) - Delete aggregate-category-trends.ts + its test (only used by the card) Category filtering still works via the sidebar (Category.tsx), which shares the same localStorage-backed useSelectedCategory state — so no filter is left stuck after removal. Losing the card's tap-to-filter shortcut is accepted per the issue. Closes #107
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 67.18% 66.89% -0.29%
==========================================
Files 138 137 -1
Lines 4376 4335 -41
Branches 1195 1182 -13
==========================================
- Hits 2940 2900 -40
Misses 1218 1218
+ Partials 218 217 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
📝 WalkthroughWalkthroughRemoves the "Categories" breakdown card from the home screen. The ChangesCategoryFilterChips removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Removes the CATEGORIES breakdown card from the home screen. The card listed each category with a count and a week-over-week percentage trend (
↑ 200%,↓ 100%,new). Those up/down deltas frame the week as a score against last week — a comparison/performance lens DESIGN.md's north star explicitly avoids (self-affirmation, never KPI guilt or comparison). A↓ 100%on a category you simply didn't touch reads as "you fell off." Removing it keeps the home screen quiet.Closes #107.
Changes
<CategoryFilterChips />fromTodoList's right column + its importCategoryFilterChips.tsx(sole consumer)aggregate-category-trends.ts+ its test (only used by the card)Acceptance criteria
space-y-6column; the heading lived inside the card, so removal is structurally cleanselectedCategoryIdis shared localStorage state still driven by the sidebarCategory.tsx; the todo list query is unchanged. Losing the card's tap-to-filter shortcut is accepted per the issue.QA
pnpm typecheck,pnpm lint,pnpm build, full unit suite (654 passed / 33 skipped) green locally (CI node 24.13.0)/home+ category specs)🤖 Generated with Claude Code
Summary by CodeRabbit