Skip to content

feat(home): remove CATEGORIES breakdown card (#107)#114

Merged
ryota-murakami merged 2 commits into
mainfrom
feat/107-remove-categories-card
Jun 24, 2026
Merged

feat(home): remove CATEGORIES breakdown card (#107)#114
ryota-murakami merged 2 commits into
mainfrom
feat/107-remove-categories-card

Conversation

@ryota-murakami

@ryota-murakami ryota-murakami commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Removes the CATEGORIES breakdown card from the home screen. The card listed each category with a count and a week-over-week percentage trend (↑ 200%, ↓ 100%, new). Those up/down deltas frame the week as a score against last week — a comparison/performance lens DESIGN.md's north star explicitly avoids (self-affirmation, never KPI guilt or comparison). A ↓ 100% on a category you simply didn't touch reads as "you fell off." Removing it keeps the home screen quiet.

Closes #107.

Changes

  • Remove <CategoryFilterChips /> from TodoList's right column + its import
  • Delete CategoryFilterChips.tsx (sole consumer)
  • Delete aggregate-category-trends.ts + its test (only used by the card)

Acceptance criteria

  • Home no longer shows the CATEGORIES card (names, counts, ↑/↓ trends gone)
  • No leftover gap/heading/broken spacing — card was a child of a space-y-6 column; the heading lived inside the card, so removal is structurally clean
  • Rest of home + every other screen keeps rendering (typecheck, lint, build, 654 unit tests green)
  • Nothing left stuck in a filtered/partial state — selectedCategoryId is shared localStorage state still driven by the sidebar Category.tsx; the todo list query is unchanged. Losing the card's tap-to-filter shortcut is accepted per the issue.

QA

  • pnpm typecheck, pnpm lint, pnpm build, full unit suite (654 passed / 33 skipped) green locally (CI node 24.13.0)
  • ⏳ Web E2E is CI-only on this machine → CI run is the gate (exercises authenticated /home + category specs)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Removed the category breakdown section from the home screen, resulting in a simpler layout.
    • The rest of the home screen content and behavior remain unchanged.

The home screen's CATEGORIES card listed each category with a count and a
week-over-week percentage trend (↑ 200%, ↓ 100%, new). Those up/down deltas
frame the week as a score against last week — a comparison/performance lens
DESIGN.md's north star explicitly avoids (self-affirmation, never KPI guilt or
comparison). A '↓ 100%' on a category you simply didn't touch reads as 'you
fell off'. Removing the card keeps the home screen quiet.

- Remove <CategoryFilterChips /> from TodoList right column + its import
- Delete CategoryFilterChips.tsx (only consumer)
- Delete aggregate-category-trends.ts + its test (only used by the card)

Category filtering still works via the sidebar (Category.tsx), which shares the
same localStorage-backed useSelectedCategory state — so no filter is left stuck
after removal. Losing the card's tap-to-filter shortcut is accepted per the issue.

Closes #107
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
corelive Ready Ready Preview, Comment Jun 24, 2026 3:47pm

Request Review

@codecov-commenter

codecov-commenter commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.89%. Comparing base (888a5b1) to head (cd9ec31).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   67.18%   66.89%   -0.29%     
==========================================
  Files         138      137       -1     
  Lines        4376     4335      -41     
  Branches     1195     1182      -13     
==========================================
- Hits         2940     2900      -40     
  Misses       1218     1218              
+ Partials      218      217       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 02024e1a-3863-4621-a6a3-bcf4a79dcd46

📥 Commits

Reviewing files that changed from the base of the PR and between 42747b5 and 5eb3a96.

📒 Files selected for processing (4)
  • src/app/(main)/home/_components/CategoryFilterChips.tsx
  • src/app/(main)/home/_components/TodoList.tsx
  • src/lib/aggregate-category-trends.test.ts
  • src/lib/aggregate-category-trends.ts
💤 Files with no reviewable changes (4)
  • src/lib/aggregate-category-trends.test.ts
  • src/app/(main)/home/_components/CategoryFilterChips.tsx
  • src/lib/aggregate-category-trends.ts
  • src/app/(main)/home/_components/TodoList.tsx

📝 Walkthrough

Walkthrough

Removes the "Categories" breakdown card from the home screen. The CategoryFilterChips component (322 lines), the aggregateCategoryTrends library (211 lines) with its types, and the associated test file (235 lines) are all deleted. The import and render block are removed from TodoList.tsx.

Changes

CategoryFilterChips removal

Layer / File(s) Summary
Remove CategoryFilterChips from TodoList
src/app/(main)/home/_components/TodoList.tsx
Removes the CategoryFilterChips import and its render block; SundayDigestCard now follows WeeklySummaryCard directly with no gap.
Delete component, library, and tests
src/app/(main)/home/_components/CategoryFilterChips.tsx, src/lib/aggregate-category-trends.ts, src/lib/aggregate-category-trends.test.ts
Deletes the 322-line chip/select component, the 211-line aggregateCategoryTrends function with CategoryTrend/CategoryTrendEntry types, and the 235-line Vitest suite covering all trend-calculation and sorting cases.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Hop hop, the trend card is gone from the screen,
No more ↓ 100% to make weekdays feel mean.
The chips have been swept and the dropdown's away,
A calmer home screen greets each passing day.
Just quiet affirmation — the rabbit's preferred way! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states the home screen CATEGORIES card is being removed and matches the main change.
Linked Issues check ✅ Passed The removal of the CATEGORIES card, helper, and render block satisfies the linked issue's requirements.
Out of Scope Changes check ✅ Passed The diff stays focused on deleting the card and its support code, with no unrelated changes apparent.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/107-remove-categories-card

Comment @coderabbitai help to get the list of available commands.

@ryota-murakami ryota-murakami merged commit 2d0a438 into main Jun 24, 2026
25 checks passed
@ryota-murakami ryota-murakami deleted the feat/107-remove-categories-card branch June 24, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the "CATEGORIES" breakdown card from the home screen

2 participants