Skip to content

fix(deploy): anchor rsync excludes to transfer root to prevent exit 23 #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryota-murakami merged 1 commit into from
May 31, 2026
Merged

fix(deploy): anchor rsync excludes to transfer root to prevent exit 23 #3787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,9 @@ jobs:
return 1
fi

rsync -a --delete --exclude='.env' --exclude='logs/' --exclude='run/' "$rollback_dir"/ "$remote_dir"/
# Anchored excludes ('/'-prefixed) protect only the top-level .env/logs/run, so
# --delete can still prune stale nested node_modules (see artifact-sync rsync, exit 23).
rsync -a --delete --exclude='/.env' --exclude='/logs/' --exclude='/run/' "$rollback_dir"/ "$remote_dir"/
cd "$remote_dir"
if sudo pm2 describe server >/dev/null 2>&1; then
sudo pm2 reload ecosystem.config.js --update-env
Expand All @@ -243,7 +245,9 @@ jobs:

capture_rollback_artifacts() {
set +e
rsync -a --delete --exclude='.env' --exclude='logs/' --exclude='run/' "$remote_dir"/ "$rollback_dir"/
# Anchored excludes ('/'-prefixed) protect only the top-level .env/logs/run, so
# --delete can still prune stale nested node_modules (see artifact-sync rsync, exit 23).
rsync -a --delete --exclude='/.env' --exclude='/logs/' --exclude='/run/' "$remote_dir"/ "$rollback_dir"/
rollback_status=$?
set -e

Expand Down Expand Up @@ -337,7 +341,10 @@ jobs:
reset_staging_dir || fail_deployment "Failed to clear migration staging directory"
tar -xzf "$remote_archive" -C "$staging_dir" || fail_deployment "Failed to re-extract clean deployment artifact"

rsync -a --delete --exclude='.env' --exclude='logs/' --exclude='run/' "$staging_dir"/ "$remote_dir"/ || fail_deployment "Failed to sync deployment artifact"
# Anchor excludes with a leading '/' so they shield ONLY top-level runtime state
# (.env, logs/, run/). Unanchored patterns also matched deep node_modules dirs
# named logs/, protecting stale nested @sentry trees from --delete → rsync exit 23.
rsync -a --delete --exclude='/.env' --exclude='/logs/' --exclude='/run/' "$staging_dir"/ "$remote_dir"/ || fail_deployment "Failed to sync deployment artifact"
deployment_applied="true"

cd "$remote_dir"
Expand Down
Loading