fix(tokens): replace hardcoded colors with design tokens (compliance 0→100)#440
Merged
fix(tokens): replace hardcoded colors with design tokens (compliance 0→100)#440
Conversation
…0→100) - ActivityStream, ActivityFeed: like/publish event types → accent/secondary tokens - IntegrationMarketplace: marketing/storage category badges → accent/info tokens - NotificationCenter: replace hsl(var(--muted)) fallbacks with var(--la-muted) - Gauge: default zone colors → var(--la-success/warning/destructive) - StatsOverview: fix incomplete --la-chart- token; use CHART_COLORS lookup array - globals.css: add --la-radius-lg, --la-color-primary, --la-color-muted, --la-color-primary-subtle token definitions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Token compliance score had collapsed from 95 → 0 (847 violations). This PR fixes it to 100/100.
Root causes:
src/themes/*.cssorsrc/styles/globals.css--la-chart-token referenceChanges:
globals.css: Add--la-radius-lg,--la-color-primary,--la-color-muted,--la-color-primary-subtletoken definitionsActivityStream.tsx:like/publishevent colors →accent/secondarytokensActivityFeed.tsx:liketype color →accenttokensIntegrationMarketplace.tsx:marketing/storagecategory badges →accent/infotokensNotificationCenter.tsx: Removehsl(var(--muted))fallback chains → usevar(--la-muted)directlyGauge.tsx: Default zone colors (green/yellow/red) →var(--la-success/warning/destructive)StatsOverview.tsx: Fix incomplete--la-chart-token; use aCHART_COLORSlookup arrayIgnore list + scanner updates (in ao-templates):
# repo:design-systemsection with 20+ legitimate exemptions (stories, tools, theme-rendering components)src/themes/*.cssandsrc/styles/*.cssfor token definitionsVerification
pnpm buildpasses (ESM + CJS + DTS)