refactor(quic/tls): drop KEY_TYPE_SECP256K1 duplicate, use KeyType.SECP256K1#762
Merged
tcoratger merged 1 commit intoMay 23, 2026
Conversation
…CP256K1 The KEY_TYPE_SECP256K1 = 2 constant in quic/tls.py duplicated KeyType.SECP256K1 from transport/peer_id.py. Both encode the same libp2p protobuf key-type code; carrying two names for the same value risks drift if the enum gains entries. Drops the constant and switches the single production caller and three test sites to the enum. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`KEY_TYPE_SECP256K1: Final = 2` in `subspecs/networking/transport/quic/tls.py` duplicated `KeyType.SECP256K1` from `subspecs/networking/transport/peer_id.py` (the libp2p crypto.proto KeyType enum). Both encode the same libp2p protobuf key-type code; carrying two names for the same value risks drift if the enum gains entries.
Drops the constant and switches the single production caller (in `_encode_asn1_signed_key`) and three test sites to use `KeyType.SECP256K1` directly.
Test plan
🤖 Generated with Claude Code