Skip to content

[Merged by Bors] - feat: continuousLinearMapAt_apply_of_mem#37537

Closed
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:simps-covder
Closed

[Merged by Bors] - feat: continuousLinearMapAt_apply_of_mem#37537
grunweg wants to merge 2 commits intoleanprover-community:masterfrom
grunweg:simps-covder

Conversation

@grunweg
Copy link
Copy Markdown
Contributor

@grunweg grunweg commented Apr 2, 2026

Also mark (Pre)Trivialization.coe_linearMapAt_of_mem simp. From #36036, i.e. the path towards Ehresmann connections.

Co-authored by: Patrick Massot patrickmassot@free.fr


Open in Gitpod

@grunweg grunweg added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 2, 2026
@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Apr 2, 2026

Let's benchmark, for good measure (pun intended). I don't expect any difference, as this file is close to the leaves.

@grunweg
Copy link
Copy Markdown
Contributor Author

grunweg commented Apr 2, 2026

!bench

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

PR summary 83b8b5c245

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ continuousLinearMapAt_apply_of_mem

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@grunweg grunweg added t-differential-geometry Manifolds etc t-topology Topological spaces, uniform spaces, metric spaces, filters labels Apr 2, 2026
@leanprover-radar
Copy link
Copy Markdown

leanprover-radar commented Apr 2, 2026

Benchmark results for 9170bd1 against 83b8b5c are in. There are no significant changes. @grunweg

  • build//instructions: -3.6G (-0.00%)

Small changes (1🟥)

  • 🟥 build/module/Mathlib.Lean.Elab.InfoTree//instructions: +126.4M (+5.02%)

Also mark (Pre)Trivialization.coe_linearMapAt_of_mem simp,
and use this to golf two proofs.
From leanprover-community#36036, i.e. the path towards Ehresmann connections.

Co-authored by: Patrick Massot <patrickmassot@free.fr>
Each of these involves the newly added simp lemma.
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Apr 2, 2026
Copy link
Copy Markdown
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Apr 7, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 7, 2026
Also mark `(Pre)Trivialization.coe_linearMapAt_of_mem` simp. From #36036, i.e. the path towards Ehresmann connections.

Co-authored by: Patrick Massot <patrickmassot@free.fr>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 7, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat: continuousLinearMapAt_apply_of_mem [Merged by Bors] - feat: continuousLinearMapAt_apply_of_mem Apr 7, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 7, 2026
xroblot pushed a commit to xroblot/mathlib4 that referenced this pull request Apr 10, 2026
Also mark `(Pre)Trivialization.coe_linearMapAt_of_mem` simp. From leanprover-community#36036, i.e. the path towards Ehresmann connections.

Co-authored by: Patrick Massot <patrickmassot@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-differential-geometry Manifolds etc t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants