fix: Initial Commit for Orbital Mechanics, Vis Viva Version 2#1057
Open
hannxmarie wants to merge 2 commits intoleanprover-community:masterfrom
Open
fix: Initial Commit for Orbital Mechanics, Vis Viva Version 2#1057hannxmarie wants to merge 2 commits intoleanprover-community:masterfrom
hannxmarie wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
Author
|
Hi @jstoobysmith am I able to be added as an outside collaborator on the project so I can use branches and not forks for future updates please? Thanks! |
Member
|
Hi @hannxmarie, so we're no longer doing the branches approach in general anymore, since we the repo - it became safer just to stick with forks if that is ok. |
| namespace ClassicalMechanics | ||
|
|
||
| structure VisViva where | ||
| G : ℝ -- gravitational constant |
Member
There was a problem hiding this comment.
These doc strings should be e.g.
/-- Gravitational constant -/
G : ℝ
| structure ConfigurationSpace where | ||
| r : ℝ -- radius | ||
|
|
||
| /-- Orbital speed for a circular orbit. -/ |
Member
There was a problem hiding this comment.
Maybe a better documentation would be, something which states that this is would be the speed if the orbit is circular.
|
|
||
| /-! | ||
| # Circular Orbit Vis Viva | ||
| Defines the orbital speed for a circular orbit (v^2 = G M / r). |
Member
There was a problem hiding this comment.
Maybe a bit more detailed docs here, also explaining the name Vis Viva.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New PR for 'initial commit for orbital mechanics' since the large PhysLean to Physlib updates from March. Updated to reflect the new version of the project, and
lake buildcompiles successfully.