fix: remove html highlighting from markdown grammar#770
Open
mhuisi wants to merge 1 commit intoleanprover:masterfrom
Open
fix: remove html highlighting from markdown grammar#770mhuisi wants to merge 1 commit intoleanprover:masterfrom
mhuisi wants to merge 1 commit intoleanprover:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
mhuisi
force-pushed
the
push-wxlpxuvwwnty
branch
from
060e3e0 to
328c981
Compare
mhuisi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the highlighting for HTML tags in the TextMate grammar for Lean comments.
The Lean TextMate grammar uses a patched version of the official Markdown TextMate grammar, which includes highlighting for HTML (by deferring to VS Code's own HTML highlighting).
In most TextMate rules of the patched Markdown grammar, we explicitly account for the closing token
-/to terminate whatever rule the Markdown grammar was currently parsing, but this is not possible in the HTML grammar, since it is handled by VS Code.HTML tag highlighting in the Markdown of Lean comments isn't very useful but has caused plenty of highlighting problems in the past, so this PR removes it.