wip: Support web3 >= 1.0.0-beta.38

[sunify]

It's a more workaround rather final solution. I think we should extract web3 stuff from core and create a separate package for that. Same for ethers. Otherwise it would be kinda hard to do #82

[codecov-io]

Codecov Report

Merging #95 into master will decrease coverage by 4.32%.
The diff coverage is 5.26%.

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   84.21%   79.88%   -4.33%     
==========================================
  Files          12       13       +1     
  Lines         912     1034     +122     
==========================================
+ Hits          768      826      +58     
- Misses        144      208      +64

Impacted Files	Coverage Δ
lib/web3/AbstractMethod.js	5% <5%> (ø)
lib/helpers.js	51.85% <5.55%> (-25.08%)	⬇️
lib/transaction.js	91.78% <0%> (+1.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10a19c...8920af1. Read the comment docs.

[troggy]

FYI #66

[sunify]

Yeah, i saw it, thanks. Just don't want to drag all this web3 stuff into our precious library :-)

[troggy]

why package-lock?

[sunify]

Oh, we hadn't it before?

[troggy]

only yarn.lock

[sunify]

Ok, looks like i missed when we started use yarn in this repo :-) Will remove

[troggy]

@types/web3 still uses old Web3, so typedefs of leap-core are not going to work with latest web3 :(

testing it with leapdao/bridge-ui#163

[sunify]

Fuck. Totally forgot about typings :(

[troggy]

if we update typings here, this will break type-compatiblity with older web3, right?

[sunify]

Not sure. Will take a look at typings and what we can do.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 5.26316% with 72 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.88%. Comparing base (d10a19c) to head (8920af1).
⚠️ Report is 74 commits behind head on master.

Files with missing lines	Patch %	Lines
lib/web3/AbstractMethod.js	5.00%	38 Missing ⚠️
lib/helpers.js	5.55%	34 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
- Coverage   84.21%   79.88%   -4.33%     
==========================================
  Files          12       13       +1     
  Lines         912     1034     +122     
==========================================
+ Hits          768      826      +58     
- Misses        144      208      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.