Conversation
Owner
|
현재 변경은 merge하지 않고 종료하는 쪽으로 정리합니다. 정리 이유:
esources.qrc / .ui는 실제 safecrowd_app에 연결되지 않아, 현재 상태로는 shipped UI를 바꾸지 못합니다.
또한 기존 범위의 근거였던 #19는 더 구체적인 설계 반영 이슈들(#120, #80, #96)로 대체되어 이미 종료되었습니다. 따라서 이 PR은 close하고, 필요한 작업은 최신 main 기준에서 설계 반영 이슈를 직접 대상으로 새 PR로 다시 진행하는 것이 맞습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backup
Summary
resources.qrc를 추가하고safecrowd_appCMake 소스에 포함했습니다.Related Issue
Area
Architecture Check
application -> domain -> engine.src/domain.domainorapplicationdependencies tosrc/engine.src/as the include root.Verification
cmake --preset windows-debugcmake --build --preset build-debugctest --preset test-debugRisks / Follow-up
MainWindow.cpp로직과의 실제 연결은 후속 작업에서 진행해야 합니다.