AI-414: leave package-lock.json at the upstream version - #1
Closed
beckerfelipee wants to merge 2 commits into
Closed
AI-414: leave package-lock.json at the upstream version#1beckerfelipee wants to merge 2 commits into
beckerfelipee wants to merge 2 commits into
Conversation
npm ci only validates the dependency tree, not the root version field, so syncing the lock bought nothing and would conflict on every upstream merge.
pipalols
approved these changes
Aug 31, 2026
Verifies that a re-pushed pr-1 tag is picked up on the node.
Collaborator
Author
|
Superseded by #2, which carries these same two changes plus the uppercase PR tag. Keeping the branch for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaves
package-lock.jsonat the upstream version string and bumpspackage.jsontov0.8.6-lsw.3.npm cionly validates the dependency tree, not the rootversionfield — verified with a minimal repro (mismatched root version,npm ciexits 0). Syncing the lock therefore bought nothing, and it guarantees a conflict on every upstream tag merge inside a 1.6 MB generated file.Also the first exercise of the
pull_requesttrigger, so this PR should publishghcr.io/leaseweb/librechat:pr-1.AI-414