fix(renderer): reject javascript: location assignments without ghosting href - #260
Open
BibekPathak wants to merge 1 commit into
Open
fix(renderer): reject javascript: location assignments without ghosting href#260BibekPathak wants to merge 1 commit into
BibekPathak wants to merge 1 commit into
Conversation
Contributor
Author
|
@ldm0 check this out |
ldm0
self-requested a review
August 28, 2026 17:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning window.location (or location.href) to a javascript: URL on a
top-level window wrote the raw "javascript:..." string into the location
href slot and recorded a pending top-level navigation. On delegate pages
(plain Runtime.evaluate) that navigation is never published or followed, so
location.href was left in a "ghost" state showing the javascript: string
without ever navigating, and the pending record was never cleared.
Match Chromium: leave location.href unchanged and drop the navigation
cleanly. Script execution remains intentionally absent.
"javascript" (top-level path already mirrored the child-frame guard), so
the assignment is a synchronous no-op for href.
state when a javascript: pending navigation is dropped on the delegate
path, instead of silently returning None with the record left behind.
The follow path is unaffected: it executes javascript: navigations inline
via take_pending_location_navigation_with_seed and never goes through the
non-javascript filter.
Tests: add a vm-level test asserting href stays unchanged, the pending
navigation is retained until dropped, and publication clears it; add a
delegate-page CDP test asserting location.href and document.title are
unchanged after a javascript: assignment.