Repository navigation
fix(settings): join Language and Units in one group - #2058
Merged
Merged
Conversation
The Units row was appended to the page instead of the Language group, so it rendered as a separate card with no gap. Put both rows in one group headed LANGUAGE & UNITS, translated in every catalog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Settings → General, the Units row was appended to the page instead of the Language group, so it rendered as a separate card with no gap, outside any group. Language and Units now share one joined group, like other settings sections, under the heading LANGUAGE & UNITS, translated in all thirteen catalogs.
Visual evidence
How to test
units, then forlanguage.Expected result: The section is headed LANGUAGE & UNITS, or its translation, with Language and Units joined in one card. Each search shows the heading with only the matching row.
Related issue
Closes #2057