Repository navigation
fix(sidebar): line up section chevrons and device eject icons - #2060
Merged
Merged
Conversation
Give the section chevron the same right gap as the title's left gap, and drop its action-sized slot. Device action icons share the chevron's size and inset, so the eject triangle's tip sits under the chevron's tip at every text size; the release spinner uses the same column. Remove the eject button's hover pill. With the icon off-centre in its button, the keyboard focus ring moves onto the icon and no longer shows after a mouse click.
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The chevron on the sidebar's collapsible headers sat further from the right edge than the title sits from the left, and the eject icon didn't line up with it.
This replaces the chevron centring from #1992, which aligned the two icons further in from the edge.
Visual evidence
N/A: agents cannot upload attachments. In words: the header's left and right gaps measure within 1px of each other, and the chevron and eject tips share a column.
How to test
PINNEDheader and compare the gap left of the title with the gap right of the chevron.DEVICESchevron, then hover the eject icon.Expected result: the gaps match and the two tips line up at each size. Hovering the eject icon brightens it without a pill, while the row's highlight runs behind it to the row's right edge. Keyboard focus shows one compact ring around the icon.
Related issue
Closes #2059