Set julia compat floor to 1.10#60
Merged
Merged
Conversation
The julia = "1" bound was dishonest: AtomsBase 0.5 requires julia >= 1.9 and extxyz_jll 0.4.4 is built for >= 1.6, so the package cannot install or load on old Julia. General's AutoMerge tests the lowest declared version (1.1.1) and failed Pkg.add/import there, blocking registration. Set the floor to 1.10, matching the CI matrix (the current LTS). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 90.54% 91.01% +0.47%
==========================================
Files 3 3
Lines 423 423
==========================================
+ Hits 383 385 +2
+ Misses 40 38 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks registration of v0.4.4. General's AutoMerge tests installing/loading on the lowest declared Julia version; with
julia = "1"that was 1.1.1, wherePkg.add/importfail because AtomsBase 0.5 requires julia ≥ 1.9 and extxyz_jll 0.4.4 is built for ≥ 1.6.Sets the floor to
1.10, matching the CI matrix (current LTS). No version bump — re-trigger registration on the merge commit to update the existing General PR.🤖 Generated with Claude Code