This repository was archived by the owner on Nov 21, 2019. It is now read-only.
Open
Conversation
Closed
7 tasks
Contributor
Author
|
At this stage, the mixins, functions and maps are internally consistent, and obsolete variables have been replaced with map handling. What remains is to update the patterns' sass, and do a sweep of the mixins to add tests where possible. |
| $passed: type_of($candidate) == "number"; | ||
| $passed: $passed and type_of($candidate / 1px); | ||
| $passed: $passed and unitless($candidate / 1px); | ||
| @return $passed; |
Contributor
There was a problem hiding this comment.
return type_of($candidate) == "number" and unit($candidate) == "px";?
| .stylelintrc \ | ||
| gulpfile.babel.js \ | ||
| ./ | ||
| COPY libero-config/ libero-config/ |
Contributor
There was a problem hiding this comment.
I think the actual config should remain here...
| "engines": { | ||
| "node": ">=10.12" | ||
| }, | ||
| "dependencies": { |
Contributor
There was a problem hiding this comment.
Should be in devDependencies.
|
|
||
| h1 { | ||
| @include h1-typography(); | ||
| @include heading-level-typography(1, 48px); |
Contributor
There was a problem hiding this comment.
Magic number, at least shouldn't be defined here...
| @return map_get($map, $key); | ||
| } | ||
|
|
||
| @return "[Not found]"; |
Contributor
There was a problem hiding this comment.
Should be an error?
|
|
||
| @include contains { | ||
| font-size: 10px; | ||
| font-size: var(--font-size-h1); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces built-in config manager with the dedicated npm module.
Requires simultaneous updates to Sass to use values derived from Sass maps rather than now non-existent variables. This approach facilitates increased mixin use, and so increases the innate testability of the Sass codebase. N.B. This step is required to ensure the Travis build will pass